forked from milvus-io/milvus
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Markdown format (milvus-io#1485)
* Fix milvus-io#839 and improve the code quality Signed-off-by: JinHai-CN <[email protected]> * Fix compiling error and building threads number Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown quality Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown quality Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown quality Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown format Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown format Signed-off-by: JinHai-CN <[email protected]> * Fix Markdown format Signed-off-by: JinHai-CN <[email protected]>
- Loading branch information
Showing
10 changed files
with
142 additions
and
124 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,17 +10,17 @@ As for everything else in the project, the contributions to Milvus are governed | |
|
||
Before you make any contributions, make sure you follow this list. | ||
|
||
- Read [Contributing to Milvus](CONTRIBUTING.md). | ||
- Check if the changes are consistent with the [coding style](CONTRIBUTING.md#coding-style), and format your code accordingly. | ||
- Run [unit tests](CONTRIBUTING.md#run-unit-test-with-code-coverage) and check your code coverage rate. | ||
- Read [Contributing to Milvus](CONTRIBUTING.md). | ||
- Check if the changes are consistent with the [coding style](CONTRIBUTING.md#coding-style), and format your code accordingly. | ||
- Run [unit tests](CONTRIBUTING.md#run-unit-test-with-code-coverage) and check your code coverage rate. | ||
|
||
## What contributions can I make? | ||
|
||
Contributions to Milvus fall into the following categories. | ||
|
||
1. To report a bug or a problem with documentation, please file an [issue](https://github.com/milvus-io/milvus/issues/new/choose) providing the details of the problem. If you believe the issue needs priority attention, please comment on the issue to notify the team. | ||
2. To propose a new feature, please file a new feature request [issue](https://github.com/milvus-io/milvus/issues/new/choose). Describe the intended feature and discuss the design and implementation with the team and community. Once the team agrees that the plan looks good, go ahead and implement it, following the [Contributing code](CONTRIBUTING.md#contributing-code). | ||
3. To implement a feature or bug-fix for an existing outstanding issue, follow the [Contributing code](CONTRIBUTING.md#contributing-code). If you need more context on a particular issue, comment on the issue to let people know. | ||
1. To report a bug or a problem with documentation, please file an [issue](https://github.com/milvus-io/milvus/issues/new/choose) providing the details of the problem. If you believe the issue needs priority attention, please comment on the issue to notify the team. | ||
2. To propose a new feature, please file a new feature request [issue](https://github.com/milvus-io/milvus/issues/new/choose). Describe the intended feature and discuss the design and implementation with the team and community. Once the team agrees that the plan looks good, go ahead and implement it, following the [Contributing code](CONTRIBUTING.md#contributing-code). | ||
3. To implement a feature or bug-fix for an existing outstanding issue, follow the [Contributing code](CONTRIBUTING.md#contributing-code). If you need more context on a particular issue, comment on the issue to let people know. | ||
|
||
## How can I contribute? | ||
|
||
|
@@ -34,11 +34,11 @@ The Milvus team members will review your pull requests, and once it is accepted, | |
|
||
Please create a new branch from an up-to-date master on your fork. | ||
|
||
1. Fork the repository on GitHub. | ||
2. Clone your fork to your local machine with `git clone [email protected]:<yourname>/milvus-io/milvus.git`. | ||
3. Create a branch with `git checkout -b my-topic-branch`. | ||
4. Make your changes, commit, then push to to GitHub with `git push --set-upstream origin my-topic-branch`. You must record your changes in [CHANGELOG.md](CHANGELOG.md) with issue numbers and descriptions. | ||
5. Visit GitHub and make your pull request. | ||
1. Fork the repository on GitHub. | ||
2. Clone your fork to your local machine with `git clone [email protected]:<yourname>/milvus-io/milvus.git`. | ||
3. Create a branch with `git checkout -b my-topic-branch`. | ||
4. Make your changes, commit, then push to to GitHub with `git push --set-upstream origin my-topic-branch`. You must record your changes in [CHANGELOG.md](CHANGELOG.md) with issue numbers and descriptions. | ||
5. Visit GitHub and make your pull request. | ||
|
||
If you have an existing local repository, please update it before you start, to minimize the chance of merge conflicts. | ||
|
||
|
@@ -53,10 +53,10 @@ git checkout -b my-topic-branch | |
|
||
Before sending your pull requests for review, make sure your changes are consistent with the guidelines and follow the Milvus coding style. | ||
|
||
- Include unit tests when you contribute new features, as they help to prove that your code works correctly, and also guard against future breaking changes to lower the maintenance cost. | ||
- Bug fixes also require unit tests, because the presence of bugs usually indicates insufficient test coverage. | ||
- Keep API compatibility in mind when you change code in Milvus. Reviewers of your pull request will comment on any API compatibility issues. | ||
- When you contribute a new feature to Milvus, the maintenance burden is (by default) transferred to the Milvus team. This means that the benefit of the contribution must be compared against the cost of maintaining the feature. | ||
- Include unit tests when you contribute new features, as they help to prove that your code works correctly, and also guard against future breaking changes to lower the maintenance cost. | ||
- Bug fixes also require unit tests, because the presence of bugs usually indicates insufficient test coverage. | ||
- Keep API compatibility in mind when you change code in Milvus. Reviewers of your pull request will comment on any API compatibility issues. | ||
- When you contribute a new feature to Milvus, the maintenance burden is (by default) transferred to the Milvus team. This means that the benefit of the contribution must be compared against the cost of maintaining the feature. | ||
|
||
### Developer Certificate of Origin (DCO) | ||
|
||
|
@@ -80,10 +80,10 @@ $ git commit -s -m 'This is my commit message' | |
The coding style used in Milvus generally follow [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). | ||
And we made the following changes based on the guide: | ||
|
||
- 4 spaces for indentation | ||
- Adopt .cpp file extension instead of .cc extension | ||
- 120-character line length | ||
- Camel-Cased file names | ||
- 4 spaces for indentation | ||
- Adopt .cpp file extension instead of .cc extension | ||
- 120-character line length | ||
- Camel-Cased file names | ||
|
||
### Format code | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.