Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4 icons, link 2 icons, fix 4 icons. #1680

Closed
wants to merge 11 commits into from

Conversation

Autines
Copy link
Contributor

@Autines Autines commented Dec 17, 2023

Description

Icons addition information

Icons added

  • Appshare (info.muge.appshare)
  • Feizhu (com.taobao.trip)
  • Todesk (youqu.android.todesk)
  • Alicloud (com.alicloud.databox)

Icons link fixed

  • baidumap (com.baidu.BaiduMap/com.baidu.baidumaps.WelcomeScreen.Alias0)
  • devcheck (flar2.devcheck/flar2.devcheck.MainActivity)
  • didi (com.sdu.didi.psnger/com.didi.sdk.app.MainActivity)
  • libchecker (com.absinthe.libchecker/com.absinthe.libchecker.features.home.ui.MainActivity)

Icons linked

  • legado (linked io.legado.play.release to @drawable/legado)
  • netease_music (linked com.hihonor.cloudmusic to @drawable/netease_music)

Contributor's checklist

  • I have followed the Lawnicons Guidelines
  • I have ensured that Lawnicons builds correctly
  • I am willing to make changes to my icons if someone suggests changes

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Dec 17, 2023
app/assets/appfilter.xml Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon is a little hard to recognize because there is no nose. Would you mind adding it?
Screenshot 2023-12-17 at 19 54 28

Copy link
Contributor Author

@Autines Autines Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, but a little ugly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size became incorrect because you reduced the thickness of the stroke but did not enlarge the icon.

Screenshot 2023-12-23 at 15 38 20
The nose can be done neatly.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Dec 17, 2023
@Autines Autines requested a review from x9136 December 23, 2023 11:00
Copy link
Contributor

Thanks for your interest in contributing! Unfortunately, we have marked this PR as stale because it has been open for 1 month with no activity. Please apply the suggested changes if there are any, and comment something related to your PR. If you don't take any action for 2 weeks, the PR will be closed.

@github-actions github-actions bot added the stale label Jan 23, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

As stated in my previous comment, this PR was closed because it has been stale for another 2 weeks with no activity. Thanks for your interest in contributing though!

@github-actions github-actions bot closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants