Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6 new icons #2490

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

RaduBratan
Copy link
Contributor

Description

Added 6 new icons, mostly Romanian apps.

Icons addition information

Added

Ace Racer (com.netease.racerna)
Action Notch (com.androxus.touchthenotch)
Blue (com.package.app)
CFR Călători (com.Infofer.ImtMobile)
MyEMC (ro.enayati.app)
Recorder.ro(ro.recorder.app)

Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Dec 20, 2024
@x9136
Copy link
Collaborator

x9136 commented Dec 31, 2024

ace_racer.svg fits, but the others don't for various reasons.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Dec 31, 2024
@RaduBratan
Copy link
Contributor Author

ace_racer.svg fits, but the others don't for various reasons.

Alright, I guess I'll try to create new versions. However, would it be possible to elaborate a bit on how the icons don't fit, or give your opinion on some suggestions I made below? I feel like Recorder.ro, MyEMC and Blue at the very least accurately portray the originals while following the guidelines.

The only improvements I could think of would be:

  • CFR Călători maybe doesn't need that middle line and the disconnected lower lines on the train, but the overall idea of the icon can't be improved in my opinion.
  • MyEMC could also portray the name of the company (ENAYATI in caps lock underneath the shape).
  • Blue appears like it's using 14px instead of 12, but I'll need to check. If it's using 12px, there's nothing I can really change, it's basically the Uber/Bolt logo but with other letters.
  • The Action Notch icon could use a complete overhaul, I agree on that, it was difficult to even come up with the current design.

What do you say?

@x9136
Copy link
Collaborator

x9136 commented Dec 31, 2024

action_notch.svg

Avoid close distances between strokes.

In other words, it probably needs to be simplified somehow.
Screenshot 2024-12-31 at 18 29 52

blue.svg

Avoid close distances between strokes.

The "b" is unique enough to make a high-quality icon out of it alone, rather than trying to fit 4 letters.

cfr_calatori.svg

Avoid close distances between strokes.

The lines need to be moved away from each other, and, in fact, the letters are not needed.

myemc.svg

Align icons to the visual center as much as possible within the guidelines.

By placing an icon of this shape in the center, it visually looks shifted downwards.

recorderro.svg

No fill.

There is nothing to add.

Why are reviews short now?
Our bot always writes a summary of the Lawnicons guidelines. Most of reviews are explanations of which points the contributors didn't pay attention to. It takes a lot of time, and the contributors hardly study. After 100+ reviews, I can say that a different approach is better: contributors should figure it out themselves or not waste time on icons.

… CFR Calatori. Shift MyEMC higher. Use Align Stroke to Center instead of Inside for Recorder. Turn Blue into a single letter.
@github-actions github-actions bot added docs Improvements or additions to documentation. locale Language adaptation. labels Jan 1, 2025
@github-actions github-actions bot removed docs Improvements or additions to documentation. locale Language adaptation. labels Jan 1, 2025
@RaduBratan RaduBratan marked this pull request as draft January 1, 2025 21:18
@RaduBratan
Copy link
Contributor Author

Thank you so much for taking your time to provide an incredibly detailed reply along with 3 possible versions of the Action Notch icon, on NYE of all days. I updated the icons to (hopefully) better fit the guidelines and will keep this PR as a draft to play a bit with some variations of CFR and MyEMC. I feel like CFR does actually benefit from having letters underneath the train (the icon looks like it's missing something without them), and I believe I still need to find the most visually appealing position for MyEMC.

Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants