Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add branches section in readme #200

Merged
merged 4 commits into from
Jan 8, 2025
Merged

add branches section in readme #200

merged 4 commits into from
Jan 8, 2025

Conversation

supernovahs
Copy link
Collaborator

No description provided.

MegaRedHand
MegaRedHand approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should discuss renaming branches to mainnet/testnet to make it match the Go SDK.

crates/eigensdk/README.md Outdated Show resolved Hide resolved
@supernovahs
Copy link
Collaborator Author

should we also uppercase this ?

# eigensdk-rs

eigensdk-rs is an initiative for rust developers to build AVSs on eigenlayer.

@supernovahs
Copy link
Collaborator Author

LGTM. We should discuss renaming branches to mainnet/testnet to make it match the Go SDK.

go sdk has mainnet and dev (instead of testnet)

@MegaRedHand
Copy link
Contributor

MegaRedHand commented Jan 8, 2025 •
edited
Loading

It now has an additional testnet branch: https://github.com/Layr-Labs/eigensdk-go/tree/testnet

@MegaRedHand
Copy link
Contributor

should we also uppercase this ?

Yes. Nice catch

@supernovahs
Copy link
Collaborator Author

It now has an additional testnet branch: https://github.com/Layr-Labs/eigensdk-go/tree/testnet

is there expected to be any difference between dev and testnet?
since there could be stuff that isn't on testnet but on dev

@MegaRedHand
Copy link
Contributor

Yes. Same as the middleware's testnet-holesky and dev

@supernovahs supernovahs merged commit 3300955 into main Jan 8, 2025
3 checks passed
@MegaRedHand MegaRedHand deleted the nova/branch_guidelines branch January 8, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @MegaRedHand