Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix check bindings job #247

Merged
merged 50 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
2bdc748
empty line
pablodeymo Jan 22, 2025
8e4953d
CHANGELOG updated
pablodeymo Jan 22, 2025
953efcd
pin solc version to 0.8.28
ricomateo Jan 24, 2025
f98a814
change workflow to generate bindings with make bindings
ricomateo Jan 24, 2025
816fc75
change project directory to safe directory before generating bindings
ricomateo Jan 24, 2025
b9c3222
set docker user when generating bindings
ricomateo Jan 24, 2025
fd12624
add step to show runner user
ricomateo Jan 24, 2025
3321f60
fix docker user
ricomateo Jan 24, 2025
c0eaa87
add sudo when generating bindings
ricomateo Jan 24, 2025
6c97ee0
fix: set docker user properly
ricomateo Jan 24, 2025
d31a15e
change bindings target to print user inside container
ricomateo Jan 24, 2025
c438dcc
print user id
ricomateo Jan 24, 2025
75bc08f
show bindings permissions
ricomateo Jan 24, 2025
8f50d37
show bindings permissions after generating them
ricomateo Jan 24, 2025
ffb2449
add user to docker run
ricomateo Jan 24, 2025
2e281a9
remove git safe directory
ricomateo Jan 24, 2025
d35e400
check user inside docker container
ricomateo Jan 24, 2025
fe74465
run docker command instead of makefile target
ricomateo Jan 24, 2025
115e97e
remove ls
ricomateo Jan 24, 2025
da8aa35
remove ls
ricomateo Jan 24, 2025
3de8f32
give root bindings write permissions
ricomateo Jan 24, 2025
d847133
fix bindings target
ricomateo Jan 24, 2025
1695c26
give root write permissions with chown and chmod
ricomateo Jan 24, 2025
cd14ab9
use docker-run action and foundry image instead of foundry action
ricomateo Jan 27, 2025
4801d6b
install docker in foundry container
ricomateo Jan 27, 2025
3a5886b
set working directory
ricomateo Jan 27, 2025
aec3c8b
add git safe directory inside container
ricomateo Jan 27, 2025
a7b90e7
fix format step
ricomateo Jan 27, 2025
471dafb
run cargo fmt with sudo
ricomateo Jan 27, 2025
809d6b2
add step to install rust
ricomateo Jan 27, 2025
34bf5c6
fix step
ricomateo Jan 27, 2025
efe385c
install rust in different step
ricomateo Jan 27, 2025
962a892
format bindings inside the container
ricomateo Jan 27, 2025
de7e980
revert: format the bindings inside the container
ricomateo Jan 27, 2025
34229f2
remove cargo fmt
ricomateo Jan 27, 2025
4c0bb66
add step to change bindings permissions
ricomateo Jan 27, 2025
53cb17d
run cargo fmt after changing permissions
ricomateo Jan 27, 2025
5a9ce2f
pin solc in forge bind commands
ricomateo Jan 27, 2025
d7515b3
change runner os to macos
ricomateo Jan 27, 2025
05fe7b3
try using ubuntu 22.04
ricomateo Jan 27, 2025
b661fbf
generate bindings without docker
ricomateo Jan 27, 2025
b34e509
revert changes in Makefile
ricomateo Jan 27, 2025
6109313
revert other changes
ricomateo Jan 27, 2025
d682123
change ubuntu to 24.04
ricomateo Jan 27, 2025
86ebc5e
change ubuntu version back to 22.04
ricomateo Jan 27, 2025
7885665
compare the bindings with git diff instead of diff
ricomateo Jan 27, 2025
494369d
check if git diff work with mismatching bindings
ricomateo Jan 27, 2025
fc840b3
add --check flag to git diff
ricomateo Jan 27, 2025
7d893b7
remove --check flag and add --exit-code to git diff
ricomateo Jan 27, 2025
cc4579f
fix ubuntu version
ricomateo Jan 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/bindings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: true

name: Check bindings are up to date
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v4
Expand All @@ -29,13 +29,6 @@ jobs:

- name: Show Forge version
run: forge --version

- name: Backup existing bindings
working-directory: crates/utils/src/
run: |
cp -r core/ existing_core/
cp -r middleware/ existing_middleware/
cp -r sdk/ existing_sdk/

- name: Generate new bindings
run: |
Expand All @@ -44,7 +37,4 @@ jobs:

- name: Compare existing and new bindings
working-directory: crates/utils/src/
run: |
diff existing_core/ core/
diff existing_middleware/ middleware/
diff existing_sdk/ sdk/
run: git diff --exit-code
2 changes: 1 addition & 1 deletion crates/contracts/foundry.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ out = "out"
libs = ["lib"]
fs_permissions = [{ access = "read-write", path = "./" }]
via-ir = true
# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options
# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options
Loading