Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move /contracts from /crates to root (#259) #261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: move /contracts from /crates to root (#259) #261

wants to merge 2 commits into from

Conversation

rvmz
Copy link

@rvmz rvmz commented Jan 30, 2025 •
edited
Loading

Fixes #259

What Changed?

As per #259, /contracts were moved from crates to the root foldeer

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@rvmz
Copy link
Author

rvmz commented Jan 31, 2025

hey @MegaRedHand
ptal

MegaRedHand
MegaRedHand requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @rvmz ! It seems the submodules were deleted. Could you add them back on the contracts/lib/ dir?

crates/contracts/lib/eigenlayer-middleware Show resolved Hide resolved
crates/contracts/lib/forge-std Show resolved Hide resolved
@rvmz rvmz changed the title [259] Move /contracts dir to root chore: move /contracts from /crates to root (#259) Feb 1, 2025
@rvmz
Copy link
Author

rvmz commented Feb 1, 2025

somehow missed that
thanks, it's fixed now!
@MegaRedHand

@rvmz rvmz requested a review from MegaRedHand February 1, 2025 15:06
MegaRedHand
MegaRedHand reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the submodules to track commits 92a320 of middleware and d3db4e of forge-std

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move crates/contracts dir to root
2 participants
@rvmz @MegaRedHand