-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fireblocks support READ #53
Conversation
contract_call pending -> fireblocks/developers-hub#3 think we can merge this till then |
crates/chainio/clients/fireblocks/src/list_external_accounts.rs
Outdated
Show resolved
Hide resolved
We can't run the fireblock tests in ci because the api key will expire in 2 weeks . So user will have option to run them locally by adding their keys in env |
writing the readme |
Can you add a ticket to linear so that we can track adding this in CI somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still more comments to come
AUTHORIZATION, | ||
HeaderValue::from_str(&format!("Bearer {}", token))?, | ||
); | ||
headers.insert("X-API-Key", HeaderValue::from_str(&self.api_key)?); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you don't or can't address the comment, please leave a reason why
…k-rs into supernovahs/fireblocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
Will add logger using #62 when this gets merged |
The current tests are tested using sandbox environment using my workspace values. If someone will run them, they would have to modify the test values as of the current state. The only solution to make the tests more general would be to create testing parameters for testnet, which needs a paid fireblocks access . |
@supernovahs let's do in future PRs |
closes #52