Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bls crate #69

Merged
merged 16 commits into from
Aug 13, 2024
Merged

bls crate #69

merged 16 commits into from
Aug 13, 2024

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Aug 6, 2024 •
edited
Loading

closes #49

@supernovahs
Copy link
Collaborator Author

@supernovahs supernovahs marked this pull request as ready for review August 8, 2024 12:36
@supernovahs supernovahs requested a review from dralves August 8, 2024 12:36
@supernovahs supernovahs changed the title bls crate WIP bls crate Aug 8, 2024
@supernovahs supernovahs mentioned this pull request Aug 9, 2024
Merged
@dralves
Copy link
Collaborator

dralves commented Aug 9, 2024

needs to resolve a few conflicts

@supernovahs
Copy link
Collaborator Author

@dralves fixed the conflicts

dralves
dralves reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@dralves dralves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs some cleanup

crates/chainio/clients/avsregistry/src/writer.rs Outdated Show resolved Hide resolved
crates/chainio/clients/avsregistry/src/writer.rs Outdated Show resolved Hide resolved
crates/chainio/clients/elcontracts/src/writer.rs Show resolved Hide resolved
crates/chainio/utils/src/lib.rs Outdated Show resolved Hide resolved
crates/crypto/bn254/src/lib.rs Outdated Show resolved Hide resolved
crates/services/avsregistry/src/chaincaller.rs
use eigen_types::operator::{OperatorAvsState, OperatorInfo, OperatorPubKeys, QuorumAvsState};
use eigen_utils::binding::BLSApkRegistry::G1Point;
use std::collections::HashMap;
// use alloy_primitives::{Bytes, FixedBytes, U256};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs cleanup

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have done this one delibarately. Will un comment this when integrating the new bls code into this crate and testing it?

...ples/avsregistry-write/examples/register_operator_in_quorum_with_avs_registry_coordinator.rs Show resolved Hide resolved
@supernovahs supernovahs requested a review from dralves August 12, 2024 09:02
@supernovahs supernovahs mentioned this pull request Aug 13, 2024
Closed
@supernovahs
Copy link
Collaborator Author

@dralves

@dralves dralves merged commit 82ab8ae into main Aug 13, 2024
1 check passed
@supernovahs supernovahs deleted the supernovahs/bls branch August 14, 2024 18:28
@supernovahs supernovahs restored the supernovahs/bls branch August 15, 2024 05:20
@supernovahs supernovahs deleted the supernovahs/bls branch December 2, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralves dralves dralves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bls crate bug
2 participants
@supernovahs @dralves