-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comm host client proxy return rollup blob #19
Conversation
// The preimage oracle key for each field element is the keccak256 hash of | ||
// `abi.encodePacked(cert.KZGCommitment, uint256(i))` | ||
|
||
let mut blob_key = [0u8; 96]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why we make this 96 long instead of 72? [65,88) is always just 0 bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curerntly, op uses 80 Bytes, even though their commitment is only 48 bytes. there is extra 32 Bytes.
Since our commitment is 64Bytes, so in total 96.
However, I recall the extra 32 bytes for op 4844 is for bytes alighment. We can change it later
781000e
to
12a0b47
Compare
@bxue-l2 I just rebased + fixed the README merge conflict. |
…ible) to spin up the op devnet (#21)
We should pull the decode function from eigenda_data.rs into a separate module that handles both encode and decode, called it codec. So that the bin/host/src/eigenda_fetcher/mod.rs can call the function. Inside the codec, we can more robustly do the test |
1bc16c8
to
e94a755
Compare
e94a755
to
736de0b
Compare
This reverts commit f87fd34.
Alternative approach to integrate with eigenda to #18
This PR does the follows
This PR contains #17