Create codec mod #22
Merged
Create codec mod #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
requested changes
Jan 3, 2025
samlaf
reviewed
Jan 3, 2025
samlaf
reviewed
Jan 3, 2025
samlaf
reviewed
Jan 3, 2025
samlaf
reviewed
Jan 3, 2025
|
Now use eigenda-proxy:main that has fixed the bug @samlaf another fix is that we don't require the encoded data from the struct EigenDABlobData to be power of 2. |
samlaf
approved these changes
Jan 3, 2025
op-devnet.docker-compose.yml.patch
Outdated
| @@ -18,7 +18,7 @@ index adcaea8f4..5c5e2e8ee 100644 | |||
| - --port=3100 | |||
| - --log.level=debug | |||
| - --generic-commitment="${ALTDA_GENERIC_DA}" | |||
| + image: ghcr.io/layr-labs/eigenda-proxy:v1.6.1 | |||
| + image: ghcr.io/layr-labs/eigenda-proxy:main | |||
There was a problem hiding this comment.
don't use main. pin to specific version for better reproducibility. Can also add a TODO comment to change to 1.6.2 after we release it. And describe why we need this (for the fix: link to your PR)
There was a problem hiding this comment.
added todo, will keep to main for the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pull encode and decode into its own file
This PR depends on Layr-Labs/eigenda-proxy#223
The da-server image now depends on image: ghcr.io/layr-labs/eigenda-proxy:main