Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to maili #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bump to maili #23

wants to merge 2 commits into from

Conversation

bxue-l2
Copy link
Collaborator

@bxue-l2 bxue-l2 commented Jan 11, 2025

Upgrade to maili

@bxue-l2 bxue-l2 requested a review from samlaf January 11, 2025 02:46
samlaf
samlaf reviewed Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM. why is this needed now? are we sure maili is going to be more stable than op-allow? are op-succint and kailua also going to be using maili? if not we might run into dependency hell issues

bin/client/justfile
@@ -69,7 +69,7 @@ run-client-native-against-devnet verbosity='' block_number='' rollup_config_path
L1_BEACON_RPC="http://127.0.0.1:5052"
L2_RPC="http://127.0.0.1:9545"
ROLLUP_NODE_RPC="http://127.0.0.1:7545"
ROLLUP_CONFIG_PATH="{{justfile_directory()}}/../../optimism/.devnet/rollup.json"
ROLLUP_CONFIG_PATH="/home/ubuntu/op-main-repo/.devnet/rollup.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you reverting to a path that only works on your machine? did the relative one not work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, just my local thing, will revert this line

Cargo.toml Show resolved Hide resolved
@bxue-l2
Copy link
Collaborator Author

bxue-l2 commented Jan 11, 2025 •
edited
Loading

upgrade to maili would work, unless then hokulea won't compile

But I am fine to just find a version that works with op-succint or kailua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bxue-l2 @samlaf