feat(batcher): altda->ethda failover #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
force-pushed
the
feat--op-batcher-altda-failover-to-ethda
branch
from
324a34d to
a86f871
Compare
samlaf
force-pushed
the
feat--op-batcher-altda-failover-to-ethda
branch
from
a86f871 to
2d93832
Compare
litt3
reviewed
Jan 31, 2025
| @@ -130,6 +134,10 @@ func (s *FakeDAServer) HandleGet(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| func (s *FakeDAServer) HandlePut(w http.ResponseWriter, r *http.Request) { | |||
| time.Sleep(s.putRequestLatency) | |||
| if s.failoverCount > 0 { | |||
| w.WriteHeader(http.StatusServiceUnavailable) | |||
| s.failoverCount-- | |||
There was a problem hiding this comment.
should you return in this if block, instead of continuing to call HandlePut?
| @@ -154,6 +162,11 @@ func (s *FakeDAServer) SetGetRequestLatency(latency time.Duration) { | |||
| s.getRequestLatency = latency | |||
| } | |||
|
|
|||
| // SetResponseStatusForNRequests sets the next n Put requests to return 503 status code. | |||
| func (s *FakeDAServer) SetPutFailoverForNRequests(n uint64) { | |||
| s.failoverCount = uint64(n) | |||
| countEthDACommitment := uint64(0) | ||
|
|
||
| // There is some nondeterministic timing behavior that affects whether the batcher has already | ||
| // posted batches before seeing the abvoe SetPutFailoverForNRequests behavior change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the feat--multiframe-altda-channel branch. Should merge that one first and then rebase on top.
It contains 2 commits:
Right now failover is done to calldata txs because that was trivial whereas failing over to blobs or their auto mode that switches between blobs and calldata would need a nontrivial refactor and some thinking. Not sure its worth putting effort into this atm given that the whole point of failover is that it should happen very rarely and also not last very long, but let me know if you guys think otherwise.