feat: kzg batch verification #24

anupsv · 2025-01-06T15:07:50Z

Adding batch verification per 4844 specs.
Some cleanup on the existing functions.
Added docs on functions.

… needed

bxue-l2

A thousand line PR is too heavy.

Suggestion. If we have something like this in the future, please split it, it will be a lot better

This includes code improvement and new feature.

src/errors.rs

src/helpers.rs

src/kzg.rs

bxue-l2 · 2025-01-08T19:04:43Z

Consider split kzg.rs into multiple files, right now, it contains too many orthogonal parts.

for examples

commits
file loading
compute random challenge

src/kzg.rs

src/helpers.rs

tests/kzg_test.rs

src/kzg.rs

bxue-l2 · 2025-01-09T07:52:12Z

I left many comments, but we can leave some of them open, but make sure to make a TODO comment, if not addressed. Of course, if something does not make sense, let me know

samlaf

First set of comments for all files except kzg.rs

Cargo.toml

src/kzg.rs

src/helpers.rs

tests/error_tests.rs

src/polynomial.rs

src/kzg.rs

…tion_form

Co-authored-by: Samuel Laferriere <[email protected]>

samlaf

LGTM but let's wait for @bxue-l2's approval

bxue-l2

just tested everything worked

asv and others added 5 commits January 4, 2025 06:13

adding bare changes for batch verification

55a5bf0

adding some comments

259f6b0

adding more comments

4c4bdd0

moving back to sha2

4ecd566

removing a test which is no longer needed. Removing methods no longer…

cb75b3b

… needed

samlaf changed the title ~~Adding batch verification~~ feat: kzg batch verification Jan 6, 2025

anupsv and others added 9 commits January 7, 2025 08:29

updates to method visibility, updating tests

42bc913

merging main

f3dd7f4

fmt fixes

02fa7ca

clean up

0807ce0

cleanup, optimization, inline docs

da5e5ad

removing unwanted const

b58174b

more docs and cleanup

c1c2f70

formatting

fa02398

removing unwanted comments

914e059

bxue-l2 mentioned this pull request Jan 7, 2025

Implement kzg batch verification like 4844 spec #17

Open

anupsv added 2 commits January 8, 2025 12:13

merging main

c74accf

cargo fmt and clippy

f054c19

anupsv marked this pull request as ready for review January 8, 2025 06:45

anupsv requested review from samlaf and bxue-l2 January 8, 2025 06:45

anupsv added 3 commits January 8, 2025 12:57

adding test for point at infinity

90b3d13

cleaner errors, cleanup

486f7da

adding another test case

32716fe

bxue-l2 reviewed Jan 8, 2025

View reviewed changes

src/errors.rs Outdated Show resolved Hide resolved

src/helpers.rs Show resolved Hide resolved

src/helpers.rs Show resolved Hide resolved

src/kzg.rs Outdated Show resolved Hide resolved

bxue-l2 reviewed Jan 8, 2025

View reviewed changes

src/kzg.rs Show resolved Hide resolved

src/kzg.rs Show resolved Hide resolved

anupsv added 3 commits January 9, 2025 02:10

removing unwanted errors

73bc809

adding fixes per comments

618e098

adding 4844 spec references

f7eb705

bxue-l2 reviewed Jan 9, 2025

View reviewed changes

comment fixes

61e1744

samlaf reviewed Jan 10, 2025

View reviewed changes

src/kzg.rs Outdated Show resolved Hide resolved

src/kzg.rs Show resolved Hide resolved

src/kzg.rs Show resolved Hide resolved

anupsv and others added 15 commits January 10, 2025 11:26

formatting, adding index out of bound check, removing print statement

1c2a79d

removing unwanted test, adding test for evaluate_polynomial_in_evalua…

baf5a44

…tion_form

moving test to bottom section

aa1ded9

Update src/polynomial.rs

86ceab3

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

d67adec

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

02194ba

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

bfd2fac

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/helpers.rs

1c9bcac

Co-authored-by: Samuel Laferriere <[email protected]>

updating deps, and toolchain to 1.84

f6c07eb

removing errors test, no longer useful

7531098

adding to_byte_array arg explanation

f9bb219

fmt fixes

5f9fa77

fmt and clippy fixes

cdeae7c

fixing function names and fmt

0624dc6

clippy fixes

c6f0bdd

This was referenced Jan 10, 2025

Code base store only 1 G2 SRS #33

Open

Document how to use the library, i.e how to setup the prover and verifier #34

Open

bxue-l2 and others added 2 commits January 10, 2025 11:54

Update src/helpers.rs

34b3223

Co-authored-by: Samuel Laferriere <[email protected]>

changes based on comments and discussion

808d3bf

samlaf approved these changes Jan 10, 2025

View reviewed changes

bxue-l2 approved these changes Jan 11, 2025

View reviewed changes

anupsv merged commit 4ad14ea into master Jan 11, 2025
1 check passed

anupsv deleted the adding-batch-verification branch January 11, 2025 03:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: kzg batch verification #24

feat: kzg batch verification #24

anupsv commented Jan 6, 2025

bxue-l2 left a comment

bxue-l2 commented Jan 8, 2025 •

edited

Loading

bxue-l2 commented Jan 9, 2025

samlaf left a comment

samlaf left a comment

bxue-l2 left a comment

feat: kzg batch verification #24

feat: kzg batch verification #24

Conversation

anupsv commented Jan 6, 2025

bxue-l2 left a comment

Choose a reason for hiding this comment

bxue-l2 commented Jan 8, 2025 • edited Loading

bxue-l2 commented Jan 9, 2025

samlaf left a comment

Choose a reason for hiding this comment

samlaf left a comment

Choose a reason for hiding this comment

bxue-l2 left a comment

Choose a reason for hiding this comment

bxue-l2 commented Jan 8, 2025 •

edited

Loading