Fix SnowBreakHttpClient.cs

- Undo my forget-to-delete debug code. - The thing now properly re-use buffer if possible to avoid extra memory usage.
Leayal · Aug 2, 2024 · e6e4da4 · e6e4da4
1 parent 69f4364
commit e6e4da4
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/Snowbreak/SnowBreakHttpClient.cs b/src/Snowbreak/SnowBreakHttpClient.cs
@@ -363,18 +363,25 @@ public async Task<Uri[]> FetchResourceURL(bool allowOfficialFetchingFromLauncher
                                 if (scanFoundStart != -1 && scanFoundEnd != -1)
                                 {
                                     var jsonLengthInBytes = (int)((scanFoundEnd + 1) - scanFoundStart);
-                                    if (false && tmpbuffer.Length >= jsonLengthInBytes)
+                                    if (tmpbuffer.Length >= jsonLengthInBytes)
                                     {
                                         localStream.Position = scanFoundStart;
                                         await localStream.ReadExactlyAsync(tmpbuffer, 0, jsonLengthInBytes, cancellationToken);
                                         officialJsonDataRaw = encodingANSICompat.GetString(tmpbuffer, 0, jsonLengthInBytes);
                                     }
                                     else
                                     {
-                                        var resultArray = new byte[jsonLengthInBytes];
-                                        localStream.Position = scanFoundStart;
-                                        await localStream.ReadExactlyAsync(resultArray, cancellationToken);
-                                        officialJsonDataRaw = encodingANSICompat.GetString(resultArray);
+                                        var encodeBuffer = ArrayPool<byte>.Shared.Rent(jsonLengthInBytes);
+                                        try
+                                        {
+                                            localStream.Position = scanFoundStart;
+                                            await localStream.ReadExactlyAsync(encodeBuffer, 0, jsonLengthInBytes, cancellationToken);
+                                            officialJsonDataRaw = encodingANSICompat.GetString(encodeBuffer, 0, jsonLengthInBytes);
+                                        }
+                                        finally
+                                        {
+                                            ArrayPool<byte>.Shared.Return(encodeBuffer);
+                                        }
                                     }
                                 }
                             }