Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBGL rationalization #146

Merged
merged 1 commit into from
Jan 24, 2025
Merged

NBGL rationalization #146

merged 1 commit into from
Jan 24, 2025

Conversation

iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Jan 23, 2025 •
edited
Loading

  • replacing nbgl_useCaseStaticReview() by nbgl_useCaseReview()
  • extending tests by using 2 receivers and 1 change
  • CodeQL fixes if needed

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped - not needed - will be a generic bump for the series of changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 23, 2025
View reviewed changes
tests/monero_client/monero_cmd.py Fixed Show fixed Hide fixed
tests/monero_client/monero_cmd.py Fixed Show fixed Hide fixed
@iartemov-ledger iartemov-ledger force-pushed the iar/nbgl_rationalization branch from 75bae88 to 4320b5c Compare January 23, 2025 17:06
@iartemov-ledger
NBGL rationalization
75de6f4 
- replacing nbgl_useCaseStaticReview() by nbgl_useCaseReview()
- extending tests by using 2 receivers and 1 change
@iartemov-ledger iartemov-ledger force-pushed the iar/nbgl_rationalization branch from 4320b5c to 75de6f4 Compare January 23, 2025 17:11
@iartemov-ledger iartemov-ledger marked this pull request as ready for review January 23, 2025 17:16
@iartemov-ledger
Copy link
Contributor Author

@nroggeman-ledger FYI!

@iartemov-ledger iartemov-ledger merged commit 607a0af into develop Jan 24, 2025
43 checks passed
@iartemov-ledger iartemov-ledger deleted the iar/nbgl_rationalization branch January 24, 2025 08:39
@iartemov-ledger iartemov-ledger mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nroggeman-ledger nroggeman-ledger nroggeman-ledger approved these changes

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

@tdejoigny-ledger tdejoigny-ledger Awaiting requested review from tdejoigny-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iartemov-ledger @cedelavergne-ledger @nroggeman-ledger