B2CA-1584: Port Nano on NBGL #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
10 times, most recently
from
1e4f968 to
16c345b
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
4 times, most recently
from
4895e10 to
674ba64
Compare
cedelavergne-ledger
requested review from
tdejoigny-ledger and
nroggeman-ledger
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
674ba64 to
8b34aff
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
8b34aff to
0555234
Compare
tests/snapshots/nanosp/test_use_case_streaming_review_accepted/00012.png
Outdated
Show resolved
Hide resolved
|
It seems that we have less tests for Nano devices than for Stax/Flex (24 vs 33), for example : test_use_case_address_review_refused |
This is due to the fact the tests related to the future deprecated APIs have not been used (and the corresponding API not ported) |
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
2 times, most recently
from
02f634b to
17b72cb
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
3 times, most recently
from
c7e14f6 to
a42b86b
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
a42b86b to
e66b8eb
Compare
tdejoigny-ledger
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to adapt the code and enable the flag to support NBGL on Nano devices.
AppNameandAppVersionrather than hardcoded valueNote: Needs SDK adaptations, for the moment in branch LedgerHQ/ledger-secure-sdk#838