Improve speed when importing descriptors (startup time) and some smaller changes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one of my journey improving this tool, to make it more useable and finally integrating it to the raspiblitz. This PR makes 3 things which are separated by their own commits, making them easy to review and getting them merged hopefully fast.
It changes the importing scheme of the descriptors. The old logic was to import every descriptor separately which leads to several rescan along the way. Doing this in one move lets us only load the descriptor once making the rescan time unrelated to the amount of descriptors which are loaded in
It adds a new Load wallet failure message which was maybe introduced along the way also catching an error where the wallet is already loaded and we do not recognize it.
Third thing is a small cli flag to skip the circulation check, makes testing faster because it takes to long for testing it makes life easier.
This fixes several issues one of them is #77