Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trait hierarchy, and basic implementations, for the main objects that will be used in the VM.
The objects are generic, so they are part of the
common
module. This will allow to easily test and develop the VM natively, while the Vanadium VM can reuse the same VM while just plugging the implementation of theOutsourcedMemory
.The CPU has support for all the opcodes in the riscv32i instruction set, except
FENCE
,PAUSE
,BREAK
andECALL
. Implementations of Ecalls will be done in followups.The Risc-V CPU was integrated in the Vanadium app. At this time, running the
vnd-test
V-App continues until the first ECALL, and crashes there.Closes: #5