Updated Fabric Installer to 0.11.2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric API` to `Legacy Fabric API`, Updated to 0.11.2, Removed "standalone server installer" notice from server tab as it linked to FabricMC.
…er required. Additionally fixed the old snapshots manifest that was missing in a previous commit.
thecatcore
requested changes
Oct 27, 2023
| @@ -77,7 +77,7 @@ public static void main(String[] args) throws IOException { | |||
| HANDLERS.forEach(handler -> System.out.printf("%s %s\n", handler.name().toLowerCase(), handler.cliHelp())); | |||
| loadMetadata(); | |||
|
|
|||
| System.out.printf("\nLatest Loader: %s\n", Main.LOADER_META.getLatestVersion(false).getVersion()); | |||
| System.out.printf("\nLatest Version: %s\nLatest Loader: %s\n", GAME_VERSION_META.getLatestVersion(argumentParser.has("snapshot")).getVersion(), Main.LOADER_META.getLatestVersion(false).getVersion()); | |||
There was a problem hiding this comment.
Latest Version is not applicable to Legacy Fabric.
| @@ -41,7 +41,7 @@ public static void main(String[] args) throws IOException { | |||
| System.setProperty("javax.net.ssl.trustStoreType", "WINDOWS-ROOT"); | |||
| } | |||
|
|
|||
| System.out.println("Loading LegacyFabric Installer: " + Main.class.getPackage().getImplementationVersion()); | |||
| System.out.println("Loading Fabric Installer: " + Main.class.getPackage().getImplementationVersion()); | |||
There was a problem hiding this comment.
Why change everything else to LegacyFabric and revert back this one?
Comment on lines
91
to
92
| libraries.add(new Library(String.format("net.fabricmc:fabric-loader:%s", loaderVersion.name), null, loaderVersion.path)); | ||
| libraries.add(new Library(String.format("net.fabricmc:intermediary:%s", gameVersion), "https://maven.fabricmc.net/", null)); |
There was a problem hiding this comment.
Why again? Legacy Fabric intermediaries are on our maven, not on official fabric one
|
I apologize for the overlooked changes, they should be fixed now. |
thecatcore
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy Fabric Installer