fix TE distributed tests with fsdp_v2 and ddp_v2 #1690
+27
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
commented
Jan 24, 2025
| @@ -124,6 +124,7 @@ def transform_module( | |||
| cd = get_compile_data(thunder_model) | |||
| # TODO: promote use_fsdp and use_ddp to public members of CompileData | |||
| cd.use_fsdp = True | |||
| cd.process_group_for_ddp = self.process_group | |||
There was a problem hiding this comment.
ddp_v2 also has it -
And TE executor needs it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TE Distributed tests were failing with
only ThunderModules support the FSDP TransformTested with
thunder/tests/distributed/test_fsdp.py -k transformer -vandthunder/tests/distributed/test_ddp.py -k transformer -von TE v1.14Related: #1640