Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated model_checkpoint.py to add the facility of retaining periodic checkpoints #20547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arijit-hub
Copy link

@arijit-hub arijit-hub commented Jan 14, 2025

… checkpoints

What does this PR do?

This decouples the save_top_k from saving intermediate checkpoints when setting every_n_epochs or every_n_steps to some value. This is a direct solution to close #20539 and further motivation can be gathered from the thread's discussion.

  • [x]Was this discussed/agreed via a GitHub issue? (not for typos and docs) : Yes. See top_k parameter of ModelCheckpoint default value #20539
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs): NO. It just add a new condition and seems to work.
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@Borda @lantiga

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top_k parameter of ModelCheckpoint default value
1 participant