feat: add registry deposits, withdraws #1038
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
requested review from
sergeytimoshin,
SwenSchaeferjohann and
vadorovsky
as code owners
vadorovsky
reviewed
Jul 29, 2024
| } | ||
|
|
||
| // Retrieve the event. | ||
| // let event = simulation_result |
There was a problem hiding this comment.
I guess this can be removed.
vadorovsky
reviewed
Jul 30, 2024
| } | ||
| // else if signer_is_delegate.is_some() && input_token_data.delegate_index.is_none() { |
| input_compressed_accounts: &[CompressedAccount], | ||
| input_merkle_context: &[MerkleContext], | ||
| input_compressed_accounts: &[CompressedAccountWithMerkleContext], | ||
| // input_merkle_context: &[MerkleContext], |
There was a problem hiding this comment.
This file looks empty. Can we remove?
| /// CHECK: | ||
| #[account(seeds = [CPI_AUTHORITY_PDA_SEED], bump)] | ||
| pub cpi_authority: AccountInfo<'info>, | ||
| /// CHECK: |
There was a problem hiding this comment.
Suggested change
| /// CHECK: | |
| /// CHECK: Seed constraint. |
| output_pda: OutputCompressedAccountWithPackedContext, | ||
| remaining_accounts: Vec<AccountInfo<'info>>, | ||
| ) -> Result<()> { | ||
| // let cpi_context = if let Some(mut cpi_context) = cpi_context { |
| delegate_account.pending_delegated_stake_weight = delegate_account | ||
| .pending_delegated_stake_weight | ||
| .checked_add(delegate_amount) | ||
| .ok_or(RegistryError::ComputeEscrowAmountFailed)?; |
There was a problem hiding this comment.
Nice, we should aim for such checked arithmetics everywhere 👍
| no_sync, | ||
| ); | ||
|
|
||
| assert!(matches!(result, Err(error) if error == RegistryError::InvalidAuthority.into())); |
There was a problem hiding this comment.
BTW, this should also work
Suggested change
| assert!(matches!(result, Err(error) if error == RegistryError::InvalidAuthority.into())); | |
| assert!(matches!(result, Err(RegistryError::InvalidAuthority))); |
(no need to change, just saying)
refactor: allow delegate mix its own undelegated accounts with delegated accounts deposit functional tests work claiming works, delegation doesnt work undelegate works with 1 delegate
ananas-block
force-pushed
the
jorrit/feat-add-registry-deposits
branch
from
f67801d to
56d1927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.