Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove anchor dependency in js #1415

Merged
merged 19 commits into from
Jan 9, 2025
Merged

chore: remove anchor dependency in js #1415

merged 19 commits into from
Jan 9, 2025

Conversation

SwenSchaeferjohann
Copy link
Contributor

@SwenSchaeferjohann SwenSchaeferjohann commented Dec 22, 2024 •
edited
Loading

problem:
some consumers use old solana versions (1.73.5) + prefer smaller bundle size

  • add support for 1.73.5+
  • removes anchor dependency in stateless.js and compressed-token
  • removes idl dependency in js sdks
  • reduces bundle size 5mb -> 2.5mb
  • testrpc should be used with typecasting only. not relevant for consumers
  • bumps internal web3js use to latest, v1.98.0

todo

  • look into further size optimization and making the es browser bundle accessible
  • public release

@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review December 27, 2024 15:54
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as draft December 27, 2024 15:55
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review December 27, 2024 17:58
@SwenSchaeferjohann
pin js sdks to use [email protected]
7ba6eef 
wip

remove anchor from stateless.js

add buffer-layout.dt.ts

add note

wip

wip

remove anchor dep in ctoken

use bs58

fmt

wip

remove custom program id test

fix dl keyss

statelessjs bundle optimization. remove idls

rm tweetnacl, minify compressed-token lib

wip. less externals

wip: try alpha

npm release script with alpha option

wip

wip

stateless.js works with web3js 1.73.5 - alpha

wip
@SwenSchaeferjohann
Copy link
Contributor Author

ready for first pass

ananas-block
ananas-block reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it's more contained than I thought. A couple small things, and more tests would be great!

@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as draft January 9, 2025 03:44
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review January 9, 2025 03:44
sergeytimoshin
sergeytimoshin approved these changes Jan 9, 2025
View reviewed changes
js/stateless.js/src/utils/test-utils.ts
console.log(`Key ${key} not found in value`);
return false;
}
if (!deepEqual(ref[key], val[key])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circular references in objects will cause infinite recursion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will fix in separate pr

@SwenSchaeferjohann SwenSchaeferjohann merged commit 68cd27a into main Jan 9, 2025
36 of 37 checks passed
@SwenSchaeferjohann SwenSchaeferjohann deleted the swen/bump-web3js-v branch January 9, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananas-block ananas-block ananas-block approved these changes

@sergeytimoshin sergeytimoshin sergeytimoshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwenSchaeferjohann @sergeytimoshin @ananas-block