chore: cleanup & fix zero out bloom filter

[ananas-block]

Changes:

1. rename BatchState::CanBeFilled -> BatchState::Fill
2. rename *_wiped -> *_zeroed
3. initializing root history with full length
   -> needed to adapt expected len assertion in batched forester tests

[sergeytimoshin]

Suggested change

	impl BatchMetadata {
	impl BatchMetadata {
	/// Returns the number of ZKP batches contained within a single regular batch.
	pub fn get_num_zkp_batches(&self) -> u64 {
	self.batch_size / self.zkp_batch_size
	}
	/// Validates that the batch size is properly divisible by the ZKP batch size.
	fn validate_batch_sizes(batch_size: u64, zkp_batch_size: u64) -> Result<(), BatchedMerkleTreeError> {
	if batch_size % zkp_batch_size != 0 {
	return Err(BatchedMerkleTreeError::BatchSizeNotDivisibleByZkpBatchSize);
	}
	Ok(())
	}

[sergeytimoshin]

Suggested change

	if batch_size % zkp_batch_size != 0 {
	return Err(BatchedMerkleTreeError::BatchSizeNotDivisibleByZkpBatchSize);
	}
	Ok(BatchMetadata {
	Self::validate_batch_sizes(batch_size, zkp_batch_size)?;
	Ok(BatchMetadata {

[sergeytimoshin]

Suggested change

	if batch_size % zkp_batch_size != 0 {
	return Err(BatchedMerkleTreeError::BatchSizeNotDivisibleByZkpBatchSize);
	}
	Ok(BatchMetadata {
	Self::validate_batch_sizes(batch_size, zkp_batch_size)?;
	Ok(BatchMetadata {

[sergeytimoshin]

Suggested change

	self.next_full_batch_index += 1;
	self.next_full_batch_index %= self.num_batches;
	self.next_full_batch_index = (self.next_full_batch_index + 1) % self.num_batches;

[sergeytimoshin]

Suggested change

	self.currently_processing_batch_index += 1;
	self.currently_processing_batch_index %= self.num_batches;
	self.currently_processing_batch_index = (self.currently_processing_batch_index + 1) % self.num_batches;

[sergeytimoshin]

Suggested change

	self.num_batches = num_batches;
	self.batch_size = batch_size;
	// Check that batch size is divisible by zkp_batch_size.
	if batch_size % zkp_batch_size != 0 {
	return Err(BatchedMerkleTreeError::BatchSizeNotDivisibleByZkpBatchSize);
	}
	Self::validate_batch_sizes(batch_size, zkp_batch_size)?;
	self.num_batches = num_batches;
	self.batch_size = batch_size;

[sergeytimoshin]

Suggested change

	#[test]
	fn test_batch_size_validation() {
	// Test invalid batch size
	assert!(BatchMetadata::new_input_queue(10, 10, 3, 2).is_err());
	assert!(BatchMetadata::new_output_queue(10, 3, 2).is_err());
	// Test valid batch size
	assert!(BatchMetadata::new_input_queue(9, 10, 3, 2).is_ok());
	assert!(BatchMetadata::new_output_queue(9, 3, 2).is_ok());
	}