-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rate limiter #1526
feat: rate limiter #1526
Conversation
b197435
to
27b7427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. Approved but didn't merge since I assume that you want to merge 1525 before this one.
@@ -66,7 +66,7 @@ pub struct StartArgs { | |||
#[arg(long, env = "FORESTER_CU_LIMIT", default_value = "1000000")] | |||
pub cu_limit: u32, | |||
|
|||
#[arg(long, env = "FORESTER_RPC_POOL_SIZE", default_value = "20")] | |||
#[arg(long, env = "FORESTER_RPC_POOL_SIZE", default_value = "98")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice default :D
@@ -34,11 +34,14 @@ num-bigint = { workspace = true } | |||
num-traits = { workspace = true } | |||
reqwest = { workspace = true } | |||
|
|||
governor = "0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this a workspace dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only used in one crate and shouldn't be used anywhere else, so I think we're fine here.
ebd6fa3
to
c560f6e
Compare
Implemented rate limiter for rpc calls.
Forester can be run with 3 optional flags: