Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test merkle inclusion proofs with snarkjs #476

Merged
merged 4 commits into from
Feb 23, 2024
Merged

feat: test merkle inclusion proofs with snarkjs #476

merged 4 commits into from
Feb 23, 2024

Conversation

sergeytimoshin
Copy link
Contributor

No description provided.

@sergeytimoshin sergeytimoshin force-pushed the sergey/ts-prover branch 2 times, most recently from 3543528 to 8ab6567 Compare February 20, 2024 23:45
@sergeytimoshin sergeytimoshin marked this pull request as ready for review February 20, 2024 23:57
ananas-block
ananas-block requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, also could you adjust it to height 26?

circuit-lib/circuit-lib.circom/scripts/generateWitness.sh Outdated Show resolved Hide resolved
circuit-lib/circuit-lib.js/tests/merkle-tree.test.ts Outdated Show resolved Hide resolved
circuit-lib/circuit-lib.js/tests/utils/merkle-tree-circom-poseidon.ts Outdated Show resolved Hide resolved
circuit-lib/circuit-lib.js/tests/utils/merkle-tree.ts Outdated Show resolved Hide resolved
@sergeytimoshin
Update Merkle Tree circuit files and related code
0ca47ab 
Removed Merkle Tree circuit files with a height of 22 and added new ones with a height of 26. Updated the relevant tests, scripts and the rust code to reflect these changes. Also fixed a typo in the parseVerifyingKeyToRust.js file name.
@sergeytimoshin
Copy link
Contributor Author

couple comments, also could you adjust it to height 26?

Done.

@ananas-block ananas-block merged commit aeee33d into main Feb 23, 2024
4 checks passed
@ananas-block ananas-block deleted the sergey/ts-prover branch February 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky left review comments

@ananas-block ananas-block ananas-block approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergeytimoshin @vadorovsky @ananas-block