feat: forester service #774
Conversation
sergeytimoshin
requested review from
vadorovsky,
SwenSchaeferjohann and
ananas-block
as code owners
photon-api/src/models/token_data.rs
Outdated
| #[derive(Clone, Default, Debug, PartialEq, Serialize, Deserialize)] | ||
| pub struct TokenData { | ||
| #[serde(rename = "amount")] | ||
| pub amount: i32, |
There was a problem hiding this comment.
amounts are ususally u64s, Nick told me they prefer i64s because those are natively supported in postgres, but i32 seems small and risky to me. Absolute amounts with many decimals can easily be in the billions.
There was a problem hiding this comment.
same with delegate amount, and is native
There was a problem hiding this comment.
ah this is just copied from photon right?
There was a problem hiding this comment.
Yes, it's autogenerated, but it should still be u64, I'll have a look https://github.com/helius-labs/photon/blob/main/src/common/typedefs/unsigned_integer.rs#L10
| #[serde(rename = "dataHash")] | ||
| pub data_hash: String, | ||
| #[serde(rename = "discriminator")] | ||
| pub discriminator: i32, |
There was a problem hiding this comment.
discriminator for us is u64
| } | ||
| } | ||
|
|
||
| fn account_nullified(&mut self, _merkle_tree_pubkey: Pubkey, _account_hash: &str) { |
There was a problem hiding this comment.
what would be the use case for this method?
| @@ -37,3 +39,4 @@ solana-rpc-client = { git = "https://github.com/Lightprotocol/agave", branch = " | |||
| solana-rpc-client-api = { git = "https://github.com/Lightprotocol/agave", branch = "v1.18.11-enforce-cpi-tracking" } | |||
| solana-runtime = { git = "https://github.com/Lightprotocol/agave", branch = "v1.18.11-enforce-cpi-tracking" } | |||
| solana-sdk = { git = "https://github.com/Lightprotocol/agave", branch = "v1.18.11-enforce-cpi-tracking" } | |||
| solana-transaction-status = { git = "https://github.com/Lightprotocol/agave", branch = "v1.18.11-enforce-cpi-tracking" } | |||
There was a problem hiding this comment.
what is switching back to the main agave repo contingent on?
There was a problem hiding this comment.
On this commit being released:
Without it, our program tests can't track inner instructions, so we wouldn't be able to test the event emission.
forester/forester.toml
Outdated
There was a problem hiding this comment.
what do these signatures do?
There was a problem hiding this comment.
merkle_tree: address of the state merkle tree
nullifier_queue: address of the nullifier queue
payer: payer's keypair
(I added this info to the README.md)
sergeytimoshin
force-pushed
the
sergey/forester
branch
5 times, most recently
from
54dd6bc to
984cf31
Compare
sergeytimoshin
force-pushed
the
sergey/forester
branch
3 times, most recently
from
054e2f1 to
014fc98
Compare
sergeytimoshin
force-pushed
the
sergey/forester
branch
from
014fc98 to
dc59b33
Compare
sergeytimoshin
force-pushed
the
sergey/forester
branch
from
e624d00 to
5b8e2e5
Compare
…ure enabled via programs/package.json
sergeytimoshin
force-pushed
the
sergey/forester
branch
from
5b8e2e5 to
6cd33e8
Compare
sergeytimoshin
force-pushed
the
sergey/forester
branch
from
6cd33e8 to
f8e3173
Compare
The timeout for the 'forester-tests' workflow in GitHub Actions has been extended from 30 minutes to 60 minutes, improving the chance of test completion for longer running tests.
No description provided.