Add prevent authentication proxy option #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't prevent proxy connections in general, but it verifies that the same IP that is used for connecting to the Minecraft server is also used for authenticating against the Mojang servers.
|
@games647 Is this a huge issue? I honestly hate "Invalid session" errors in my client and I feel like this'll just cause more of them. Maybe make it optional? |
Not really, but some users maybe want this in order to protect from McLeaks users.
I don't know the effect on this, because Mojang will only verify additionally if the IP that is connecting to the server is the same as the IP connecting to Mojang.
Yes, then the admin could decide about the above things. Should I add a config options with default false? |
|
Should I squash the commits? |
|
@games647 Looks good will merge later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of months ago, Mojang introduced a new parameter IP for their session servers. It prevents player connections if someone uses an authentication proxy, but still wants to connect directly to the Spigot server. So it doesn't prevent proxy connections in general.