added async http request and removed old sync impl #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georg-getz
reviewed
Aug 14, 2024
georg-getz
reviewed
Aug 14, 2024
georg-getz
reviewed
Aug 14, 2024
georg-getz
approved these changes
Aug 14, 2024
Zurcusa
requested changes
Aug 14, 2024
Zurcusa
approved these changes
Aug 15, 2024
ablax
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make http requests non-blocking the previous synchronous calls are replaced with asynchronous ones. Additionally, the new implementation in the http.js script utilizes async-await syntax, which is easier to understand than the old XMLHttpRequest approach.
What does this PR do?
Fixes LimeChain#506
How were these changes implemented and what do they affect?
Changes have been made to the HttpRequest class and http.js script, which are called by the JsonUtil class. These modifications will not be visible to all users of the JsonUtil class.