Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fallback warp sync via RPC. #9

Closed
wants to merge 7 commits into from

Conversation

Zurcusa
Copy link
Collaborator

@Zurcusa Zurcusa commented Aug 29, 2024

  • What does this PR do?
    Implements a fallback rpc action for the warp sync.
  • Why are these changes needed?
    In case the warp sync protocol is not working because of faulty peer nodes or another reason that would interfere with the warp execution.
  • How were these changes implemented and what do they affect?
    Another warp action is added, "RpcFallbackAction". It is reached if the warp sync cannot start initially or an issue occurs while requesting fragments of verifying justifications.

Fixes LimeChain#494

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -68,7 +68,11 @@
// stream.end();
// });
}
// Test
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be deleted after review.

main();
// Test 2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant