Skip to content

Commit

Permalink
Update dependencies (#314)
Browse files Browse the repository at this point in the history
* feat: update `polkaj-schnorrkel`

- adds the new VRF functionality
- jar built at this commit: LimeChain/polkaj@3327211

* feat: update `wasmer-java`; add more targets

- add a fresh build of wasmer-java at LimeChain/wasmer-java@cb4fafe

- add more target platforms (+linux and windows)

* chore: add some known todos to `TODO.md`
  • Loading branch information
David-Petrov authored Mar 14, 2024
1 parent 77cb0a9 commit af93a69
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export JAVA_HOME=`/usr/libexec/java_home -v 17.0.8`
Note: This step will be automated in the future
```

Depending on your architecture type, you will have to grab one of either 2 versions(arm/amd) of the wasmer-java dylib
file from `wasmer-setup` folder.
For now, you will have to manually grab the compiled `wasmer-java` dynamic library
file from the subfolder under `./wasmer-setup` corresponding to your architecture type.
Copy the file to the Java `Extensions` folder:

```
Expand Down
Binary file removed libs/polkaj-schnorrkel-0.5.1-SNAPSHOT.jar
Binary file not shown.
Binary file added libs/polkaj-schnorrkel-0.5.2-SNAPSHOT.jar
Binary file not shown.
5 changes: 4 additions & 1 deletion src/main/resources/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@
So: map the CLI argument to an ENUM instance and from there:
- in production, use `application.properties` to fetch the chain spec path;
- in test, use another properties file (spring profiles could help) or implement local test-case specific map from enum to paths... something like that
- Add exception handling (Error Resolver while creating the JSONRPC server) for RPC calls, as currently we are leaking classpath to the exceptions and not using the suggested error codes from the JSON-RPC spec. Look into (./libs/jsonrpc4j-1.6.2-SNAPSHOT.jar!/com/googlecode/jsonrpc4j/JsonRpcBasicServer.class:468)
- Add exception handling (Error Resolver while creating the JSONRPC server) for RPC calls, as currently we are leaking classpath to the exceptions and not using the suggested error codes from the JSON-RPC spec. Look into (./libs/jsonrpc4j-1.6.2-SNAPSHOT.jar!/com/googlecode/jsonrpc4j/JsonRpcBasicServer.class:468)
- Revisit the conversations on the VRF proofs PR from within PolkaJ's Schnorrkel wrapper [here](https://github.com/LimeChain/polkaj/pull/2). Goal: we're waiting for potential upgrade of `robusta` to a newer jni to refine the ugly hacks in our solution. More details in the PR conversation.
- Make `wasmer-java` load the native libraries as dynamic libs and remove the need for manual intervention for the user from [the README](https://github.com/LimeChain/Fruzhin/blob/dev/README.md#wasmer-java-dylib-setup). In other words, add the mentioned "automation later" :D
I'd suggest a similar approach to what's in `polkaj-schnorrkel`, still not ideal for the dev, but definitely better for the user.
Binary file added wasmer-setup/linux/amd/libwasmer_jni.so
Binary file not shown.
Binary file added wasmer-setup/linux/arm/libwasmer_jni.so
Binary file not shown.
Binary file added wasmer-setup/linux/i686/libwasmer_jni.so
Binary file not shown.
File renamed without changes.
File renamed without changes.
Binary file added wasmer-setup/windows/amd/wasmer_jni.dll
Binary file not shown.

0 comments on commit af93a69

Please sign in to comment.