399 Attempt to finalize at round #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able and place it to the methods where they are calculated
georg-getz
reviewed
Jan 22, 2025
| ); | ||
|
|
||
| long totalVoters = grandpaSetState.getAuthorities().size(); | ||
| long threshold = (2 * totalVoters) / 3; |
There was a problem hiding this comment.
Can you put a comment with a link showing how these numbers were chosen or explain them in he comment, because they look like magic numbers right now.
georg-getz
reviewed
Jan 22, 2025
| } | ||
|
|
||
| public void cleanCommitMessagesArchive() { | ||
| commitMessagesArchive.remove(setId.subtract(BigInteger.TWO)); |
There was a problem hiding this comment.
Why are we subtracting 2 here?
There was a problem hiding this comment.
The only reason is that we will only need the commit messages for the current set and in the edge case also the commit messages from the previous set. By subtracting 2 I delete commit messages for older sets. I will add a comment about the reason behind that action because this is not defined in the spec.
…und getters when fields are null
|
Zurcusa
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getBestFinalCandidate,getGrandpaGhostandgetBestPreVoteCandidatetofindBestFinalCandidate,findGrandpaGhostandfindBestPreVoteCandidatein theGrandpaServicein order not to have different names from theGrandpaRoundgettersGrandpaGhostandBestFinalCandidatefields of theGrandpaRoundobject are now being set directly in the methodsfindGrandpaGhost()andfindBestFinalCandidate(), rather than inisFinalizable()commitMessagesArchive, a map ofSetIdas a key, and a list of commit messages as value. On every new set start the commit messages for (setId - 2) are deleted because they will probably never be used again.Fixes: #399