-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isActiveAuthority and GrandpaKeyPair fields to AbstractState #714
Conversation
@Getter | ||
protected boolean initialized; | ||
|
||
@Getter | ||
private static SyncMode syncMode; | ||
@Getter | ||
protected boolean initialized; | ||
private static boolean isActiveAuthority = false; | ||
@Getter | ||
private static Pair<byte[], byte[]> grandpaKeyPair = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If every single field needs a getter than you should put the annotation on the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This annotation can also be applied to a class, in which case it'll be as if all non-static fields that don't already have a Getter annotation have the annotation." taken from lombok documentation for Getter. I tried applying it only to the class, but it doesn't generate getters for the static fields.
public static void unsetAuthorityStatus() { | ||
isActiveAuthority = false; | ||
grandpaKeyPair = null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "clear" better than "unset"
Quality Gate passedIssues Measures |
Description
byte[]
in order to work for both SR25519(Babe) and ED25519(Grandpa) key pairs.Fixes #713