refactor: #666 Refactor states and services. #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description This PR aims to improve the overall structure of Fruzhin in 2 ways: - Add a shared interface for services (sync and network, babe and grandpa are to follow) `NodeService`. This enables services to share a class signature and be started/stopped in a similar fashion. It also helps separate what services are required and started for each type of node. - Add a shared interface for states (block, sync, epoch, grandpa and transaction) `ServiceState`. Reasoning is similar to the service one, but it also aims to centralize the initialization of the states as they were not concise. It also prepares Fruzhin to follow the Runtime to Consensus engine communication. (initializing states at genesis and using consensus message to update)
…states # Conflicts: # src/main/java/com/limechain/grandpa/state/RoundState.java
# Description feat: Add ServiceConsensusState interface with populateFromRuntime() method - Introduced `ServiceConsensusState` interface to define the initializeFromRuntime() method for RoundState and EpochState as requiring runtime data. - Implemented populateFromRuntime() - Integrated these state initializations within FullSyncMachine to ensure proper synchronization during node startup. Fixes #687 --------- Co-authored-by: Hristiyan Mitov <[email protected]>
**Description** feat: Introduced the StateManager class to centralize and manage all state instances. Additionally, fixed comments from PR. Fixes #687 --------- Co-authored-by: Hristiyan Mitov <[email protected]>
# Conflicts: # src/main/java/com/limechain/grandpa/GrandpaService.java # src/main/java/com/limechain/grandpa/state/GrandpaSetState.java # src/main/java/com/limechain/network/protocol/message/ProtocolMessageBuilder.java # src/main/java/com/limechain/rpc/config/CommonConfig.java # src/main/java/com/limechain/storage/block/BlockHandler.java # src/main/java/com/limechain/sync/warpsync/WarpSyncMachine.java # src/main/java/com/limechain/sync/warpsync/WarpSyncState.java # src/main/java/com/limechain/sync/warpsync/action/VerifyJustificationAction.java # src/test/java/com/limechain/grandpa/GrandpaServiceTest.java
# Description Adapt block handling to the latest changes after refactoring.
…states # Conflicts: # src/main/java/com/limechain/babe/BabeService.java # src/main/java/com/limechain/grandpa/GrandpaService.java # src/main/java/com/limechain/grandpa/state/GrandpaSetState.java # src/main/java/com/limechain/rpc/config/CommonConfig.java # src/test/java/com/limechain/grandpa/GrandpaServiceTest.java # src/test/java/com/limechain/network/protocol/grandpa/GrandpaEngineTest.java
…states # Conflicts: # src/main/java/com/limechain/grandpa/GrandpaService.java # src/main/java/com/limechain/rpc/config/CommonConfig.java # src/main/java/com/limechain/sync/warpsync/WarpSyncState.java # src/test/java/com/limechain/grandpa/GrandpaServiceTest.java
Grigorov-Georgi
approved these changes
Jan 27, 2025
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See the following PRs:
#688
#701
#691