test(frame): tx-payment (#236)

* test(frame): tx-payment

* refactor

* more test cases

frame/transaction_payment/event_test.go

@@ -0,0 +1,40 @@
+package transaction_payment
+
+import (
+	"bytes"
+	"testing"
+
+	sc "github.com/LimeChain/goscale"
+	"github.com/LimeChain/gosemble/primitives/types"
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_DecodeEvent(t *testing.T) {
+	buffer := bytes.NewBuffer([]byte{})
+	expectedEvent := NewEventTransactionFeePaid(moduleId, who.FixedSequence, sc.NewU128(7), sc.NewU128(1))
+	expectedEvent.Encode(buffer)
+
+	result := DecodeEvent(moduleId, buffer)
+
+	assert.Equal(t, expectedEvent, result)
+}
+
+func Test_DecodeEvent_ModuleIndexError(t *testing.T) {
+	buffer := bytes.NewBuffer([]byte{})
+	expectedEvent := NewEventTransactionFeePaid(moduleId, who.FixedSequence, sc.NewU128(7), sc.NewU128(1))
+	expectedEvent.Encode(buffer)
+
+	assert.PanicsWithValue(t, "invalid transaction_payment.Event module", func() {
+		DecodeEvent(sc.U8(123), buffer)
+	})
+}
+
+func Test_DecodeEvent_TypeError(t *testing.T) {
+	buffer := bytes.NewBuffer([]byte{})
+	expectedEvent := types.NewEvent(moduleId, 99, who.FixedSequence, sc.NewU128(7), sc.NewU128(1))
+	expectedEvent.Encode(buffer)
+
+	assert.PanicsWithValue(t, "invalid transaction_payment.Event type", func() {
+		DecodeEvent(moduleId, buffer)
+	})
+}

frame/transaction_payment/extensions/charge_transaction_payment.go

@@ -76,12 +76,20 @@ func (ctp ChargeTransactionPayment) PostDispatch(pre sc.Option[primitives.Pre],
 		imbalance := preValue[2].(sc.Option[primitives.Balance])
 
 		actualFee := ctp.txPaymentModule.ComputeActualFee(sc.U32(length.ToBigInt().Uint64()), *info, *postInfo, tip)
+
 		err := ctp.onChargeTransaction.CorrectAndDepositFee(who, actualFee, tip, imbalance)
 		if err != nil {
 			return err
 		}
 
-		ctp.systemModule.DepositEvent(transaction_payment.NewEventTransactionFeePaid(ctp.txPaymentModule.GetIndex(), who.FixedSequence, actualFee, tip))
+		ctp.systemModule.DepositEvent(
+			transaction_payment.NewEventTransactionFeePaid(
+				ctp.txPaymentModule.GetIndex(),
+				who.FixedSequence,
+				actualFee,
+				tip,
+			),
+		)
 	}
 	return nil
 }