HW_18 #4
Open
HW_18 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKozlov98
reviewed
May 5, 2024
There was a problem hiding this comment.
Параллельный лес: 22/25
- Не везде есть docstring-и и аннотации к типам -4б
bioinfUtils.py— неподходящее название (camelCase , когда все остальные файлы snake_case нехорошо ) — лучше такbioinf_utils.py-1б- 3/4 примера в jupyter-ноутбуке
Showcases.ipynb-5б - кажется, вы забыли добавить
@pytest.fixtureк входным параметрам тестов, без этого они не запустятся
(только, если не вручную запускать — но тогда пропадает смысл использованияpytest). -3б
+1 балл за красивый и информативный readme
Итого: 35 баллов
|
|
||
| self.classes_ = sorted(np.unique(y)) | ||
|
|
||
| with ThreadPoolExecutor(n_jobs) as pool: |
There was a problem hiding this comment.
-3 балла (CPU-bound задача - нужны процессы)
То есть нужно было использовать ProcessPoolExecutor
| tree = DecisionTreeClassifier( | ||
| max_depth=self.max_depth, max_features=self.max_features, random_state=self.random_state+i) | ||
|
|
||
| temp_pool.append(pool.submit(tree.fit, X_sample, y_sample)) |
There was a problem hiding this comment.
непосредственный фитинг деревьев вы сделали параллельным (псевдо, конечно)
но забыли про подготовку данных и создание объекта дерева -- было бы здорово также делать это параллельно. :)
Comment on lines
+57
to
+58
| temp_pool = [pool.submit(tree.predict_proba, X[:, self.feat_ids_by_tree[i]]) | ||
| for i, tree in enumerate(self.trees)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.