Add ERROR message and first Bus messages #5
+281
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRAFT Signed-off-by: Bertrand Marquis <[email protected]>
Signed-off-by: Bertrand Marquis <[email protected]>
Add bus messages definitions and several TODO to be discussed. Signed-off-by: Bertrand Marquis <[email protected]>
Remove Connect and Disconnect messages. Re-work the messages numbering: - Error is now 0x1 - Mark 0x0 as Reserved - Move messages down to use all numbers - Move Event messages from 0x10 to 0x20 to leave more space for future non even messages. Signed-off-by: Bertrand Marquis <[email protected]>
Define a Message ID field in error message to carry the ID of the message that triggered an error. Define a Data Type field in Error message and a value STRING (1) so that the rest of the payload of the message can be used as NULL terminating string that can be printed. Signed-off-by: Bertrand Marquis <[email protected]>
When the driver is requesting feature at an index at which no features are available and after which no more features are available, instruct to return an ERROR message so the driver knows that it does not need to scan further. Signed-off-by: Bertrand Marquis <[email protected]>
Make the chapter and content a bit more coherent with the main virtio-msg chapter. While there also reserve message ID 0 and move ERROR message to 1. Signed-off-by: Bertrand Marquis <[email protected]>
Make the bus error message more coherent with the virtio-msg one and add a possible string payload and a payload type paramter. Add some clarification on when and by who this can be sent. Signed-off-by: Bertrand Marquis <[email protected]>
Make clear that the offset is not a multiple of 32 (ie offset 1 gives availibility of device 32 to 63). Fix some wording and latex issues. Signed-off-by: Bertrand Marquis <[email protected]>
Add content and message definition for bus messages signaling that a device has been added or removed. Signed-off-by: Bertrand Marquis <[email protected]>
Add ping message description and definition with 32bit of data that must be copied back in the answer. Signed-off-by: Bertrand Marquis <[email protected]>
Add a definition of the bus status message (replaces reset message). Signed-off-by: Bertrand Marquis <[email protected]>
|
I added more patches to handle the changes discussed during the HVAC meeting on the 30/01/2025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains 3 patches:
I added some TODOs as there are various subjects that we will need to discuss there.