Merge pull request #1908 from LiskHQ/1876-incorrect-validators-rank

Incorrect validators rank
LiskArchive · Oct 31, 2023 · 8a5104d · 8a5104d
2 parents 3cfebbc + 79386df
commit 8a5104d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/services/blockchain-indexer/shared/dataService/pos/validators.js b/services/blockchain-indexer/shared/dataService/pos/validators.js
@@ -60,7 +60,7 @@ let validatorList = [];
 const validatorComparator = (a, b) => {
 	const diff = BigInt(b.validatorWeight) - BigInt(a.validatorWeight);
 	if (diff !== BigInt('0')) return Number(diff);
-	return Buffer.from(a.hexAddress, 'hex').compare(Buffer.from(b.hexAddress, 'hex'));
+	return Buffer.from(b.hexAddress, 'hex').compare(Buffer.from(a.hexAddress, 'hex'));
 };
 
 const computeValidatorRank = async () => {

diff --git a/services/blockchain-indexer/tests/unit/shared/dataservice/pos/validators.test.js b/services/blockchain-indexer/tests/unit/shared/dataservice/pos/validators.test.js
@@ -65,22 +65,22 @@ describe('Test validatorComparator method', () => {
 		expect(result).toBeGreaterThan(0);
 	});
 
-	it('should return -1 when validator weight is same but first address is smaller', async () => {
+	it('should return 1 when validator weight is same but first address is smaller', async () => {
 		const { validatorComparator } = require(posValidatorsPath);
 		const result = validatorComparator(
 			{ validatorWeight: BigInt(1e20), hexAddress: '002e84247fd3876baca6698d98f0ace199af96ed' },
 			{ validatorWeight: BigInt(1e20), hexAddress: '0282ed03925a5c31271fa3b70bb94ce12fd83ea9' },
 		);
-		expect(result).toBe(-1);
+		expect(result).toBe(1);
 	});
 
-	it('should return 1 when validator weight is same but first address is greater', async () => {
+	it('should return -1 when validator weight is same but first address is greater', async () => {
 		const { validatorComparator } = require(posValidatorsPath);
 		const result = validatorComparator(
 			{ validatorWeight: BigInt(1e20), hexAddress: '0282ed03925a5c31271fa3b70bb94ce12fd83ea9' },
 			{ validatorWeight: BigInt(1e20), hexAddress: '002e84247fd3876baca6698d98f0ace199af96ed' },
 		);
-		expect(result).toBe(1);
+		expect(result).toBe(-1);
 	});
 
 	it('should return 0 when both validator weight and address are equal', async () => {