Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Querying events endpoint with topic, senderAddress and transactionID does not work #1873

Closed
Tracked by #1159
priojeetpriyom opened this issue Oct 6, 2023 · 0 comments · Fixed by #1878
Closed
Tracked by #1159

Comments

@priojeetpriyom
Copy link
Contributor

priojeetpriyom commented Oct 6, 2023

Actual behavior

When events endpoint is queried with topic, senderAddress and transactionID - senderAddress replaces transactionID in the internal database query.

Qerying by empty block ID or topic using RPC results in an error.

Expected behavior

  1. The endpoint should work properly supporting filtering by all params simultaneously.
  2. Following integration tests, which fail currently, should work:
    https://github.com/LiskHQ/lisk-service/blob/release/0.7.0/tests/integration/api_v3/rpc/events.test.js#L151
    https://github.com/LiskHQ/lisk-service/blob/release/0.7.0/tests/integration/api_v3/rpc/events.test.js#L532

Steps to reproduce

Invoke events endpoint above three params but provide a wrong transactionID

Which version(s) does this affect? (Environment, OS, etc...)

  • v0.7.0-rc.1

Additional information

Currently, lisk service framework do not provide an api to such a query. We may need to update the knex wrapper or do a raw query.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.