Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Conversation

vardan10
Copy link
Contributor

What was the problem?

This PR resolves #1873

How was it solved?

  • Fixed events endpoint to work with topic
  • Fixed failing integration tests
  • Added functional tests

How was it tested?

Local

@vardan10 vardan10 force-pushed the 1873-querying-events-endpoint-with-topic-senderAddress-and-transactionID-does-not-work branch from c290db8 to e72288d Compare October 18, 2023 12:05
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1878 (cb90ac6) into release/0.7.0 (64497d7) will increase coverage by 0.05%.
Report is 13 commits behind head on release/0.7.0.
The diff coverage is 91.30%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1878      +/-   ##
=================================================
+ Coverage          66.76%   66.82%   +0.05%     
=================================================
  Files                298      298              
  Lines               5118     5112       -6     
  Branches             925      922       -3     
=================================================
- Hits                3417     3416       -1     
+ Misses              1701     1696       -5     
Files Coverage Δ
...hain-indexer/tests/unit/shared/constants/events.js 100.00% <ø> (ø)
...hain-indexer/shared/dataService/business/events.js 79.24% <91.30%> (+3.35%) ⬆️

@vardan10 vardan10 force-pushed the 1873-querying-events-endpoint-with-topic-senderAddress-and-transactionID-does-not-work branch from c5f6f14 to 93f5d79 Compare October 18, 2023 15:27
@sameersubudhi sameersubudhi merged commit f14c6c4 into release/0.7.0 Oct 20, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1873-querying-events-endpoint-with-topic-senderAddress-and-transactionID-does-not-work branch October 20, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying events endpoint with topic, senderAddress and transactionID does not work
3 participants