Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk service performance issues #1902

Merged
merged 19 commits into from
Oct 30, 2023

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Oct 27, 2023

What was the problem?

This PR resolves #1900 #1903

How was it solved?

  • Disabled blocks caching by default to improve API response times (To be investigated later)
  • Optimized/reduced number of calls made to the node
  • Tweak the block indexing logic to be slightly faster (Needs further improvement from SDK, the RPC calls to fetch the blocks take significant amount of time)
  • Fix event query bug with transactionID
  • Extend blocks response to include eventRoot
  • Update script names in Makefile and package.json
  • Update documentation as per the changes made above
  • Fix the inconsistency between the stakers and validators endpoint responses
  • Fix semgrep on CI

How was it tested?

Ran against the testnet locally

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1902 (3898bbc) into release/0.7.0 (04d0de9) will decrease coverage by 0.04%.
The diff coverage is 45.83%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1902      +/-   ##
=================================================
- Coverage          66.63%   66.59%   -0.04%     
=================================================
  Files                298      298              
  Lines               5230     5245      +15     
  Branches             942      945       +3     
=================================================
+ Hits                3485     3493       +8     
- Misses              1745     1752       +7     
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <ø> (ø)
services/blockchain-indexer/config.js 100.00% <100.00%> (ø)
...hain-indexer/shared/dataService/business/blocks.js 18.47% <100.00%> (+0.52%) ⬆️
...hain-indexer/shared/dataService/business/events.js 78.68% <100.00%> (+0.35%) ⬆️
...chain-indexer/shared/dataService/business/index.js 100.00% <ø> (ø)
...ces/blockchain-indexer/shared/dataService/index.js 100.00% <ø> (ø)
...hain-indexer/tests/unit/shared/constants/events.js 100.00% <ø> (ø)
...ervices/gateway/sources/version3/mappings/block.js 100.00% <ø> (ø)
services/blockchain-indexer/shared/constants.js 53.01% <0.00%> (-0.65%) ⬇️
...indexer/shared/dataService/business/pos/stakers.js 18.03% <0.00%> (-0.31%) ⬇️
... and 1 more

@sameersubudhi sameersubudhi force-pushed the 1900-lisk-service-performance-issues branch from 1c9e108 to f74ec5a Compare October 28, 2023 10:56
@sameersubudhi sameersubudhi force-pushed the 1900-lisk-service-performance-issues branch from f74ec5a to 372012c Compare October 28, 2023 11:07
@sameersubudhi sameersubudhi force-pushed the 1900-lisk-service-performance-issues branch 4 times, most recently from 6619b95 to 480ef36 Compare October 29, 2023 22:27
@sameersubudhi sameersubudhi force-pushed the 1900-lisk-service-performance-issues branch from 480ef36 to f30c63e Compare October 29, 2023 22:35
@sameersubudhi sameersubudhi merged commit 5bdcfb1 into release/0.7.0 Oct 30, 2023
@sameersubudhi sameersubudhi deleted the 1900-lisk-service-performance-issues branch October 30, 2023 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants