Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Optimize retry mechanism in invokeEndpoint #1905

Merged

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #1904

How was it solved?

  • Tweak the setting in client.js

How was it tested?

  • Locally against the testnet
    • Block indexing time is now reduced to ~50-150ms from over ~1-1.5sec. Verified with console.time

@sameersubudhi sameersubudhi self-assigned this Oct 31, 2023
@sameersubudhi sameersubudhi marked this pull request as draft October 31, 2023 10:02
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1905 (5001c66) into release/0.7.0 (8b1c9a3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1905      +/-   ##
=================================================
+ Coverage          66.59%   66.62%   +0.03%     
=================================================
  Files                298      298              
  Lines               5245     5250       +5     
  Branches             945      949       +4     
=================================================
+ Hits                3493     3498       +5     
  Misses              1752     1752              
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <100.00%> (ø)
services/blockchain-indexer/config.js 100.00% <100.00%> (ø)

@sameersubudhi sameersubudhi marked this pull request as ready for review October 31, 2023 10:09
@sameersubudhi sameersubudhi changed the base branch from development to release/0.7.0 October 31, 2023 10:13
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 3cfebbc into release/0.7.0 Oct 31, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1903-optimize-retry-mechanism-in-invokeEndpoint branch October 31, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize retry mechanism in invokeEndpoint
3 participants