Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Redis OOM errors #1927

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Redis OOM errors #1927

merged 6 commits into from
Nov 16, 2023

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Nov 15, 2023

What was the problem?

This PR resolves #1919

How was it solved?

  • Fix getLiveIndexingJobCount to include deletedBlocksIndexing job count (RC for OOM)
  • Await when scheduling block deletion to be successfully added to the job queue
  • Fix topics mapping for relayerFeeProcessed event
  • Fix issues with client.js
  • Fix edgecase scenario handling when setting IndexVerifiedHeight
  • Decrease generatedBlocks count for the generator when handling deleted blocks

How was it tested?

Locally against testnet

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1927 (a86ece0) into release/0.7.0 (7879da7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1927   +/-   ##
==============================================
  Coverage          67.01%   67.01%           
==============================================
  Files                298      298           
  Lines               5254     5254           
  Branches             954      954           
==============================================
  Hits                3521     3521           
  Misses              1733     1733           

@sameersubudhi sameersubudhi requested review from priojeetpriyom and removed request for nagdahimanshu November 15, 2023 17:22
@sameersubudhi
Copy link
Contributor Author

Not merging the PR yet. There's still some unidentified issue remaining in the codebase.

@sameersubudhi sameersubudhi marked this pull request as draft November 15, 2023 17:44
@sameersubudhi sameersubudhi marked this pull request as ready for review November 16, 2023 15:42
@priojeetpriyom priojeetpriyom merged commit bc47bcc into release/0.7.0 Nov 16, 2023
8 checks passed
@priojeetpriyom priojeetpriyom deleted the 1919-redis-oom-errors branch November 16, 2023 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants