This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Add receivingChainID request param support to transactions endpoint #1934
Merged
sameersubudhi
merged 8 commits into
release/0.7.0
from
1931-add-receivingChainID-request-param-support-to-transactions-endpoint
Nov 23, 2023
Merged
Add receivingChainID request param support to transactions endpoint #1934
sameersubudhi
merged 8 commits into
release/0.7.0
from
1931-add-receivingChainID-request-param-support-to-transactions-endpoint
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vardan10
force-pushed
the
1931-add-receivingChainID-request-param-support-to-transactions-endpoint
branch
from
November 22, 2023 16:18
a24fa76
to
91ebf92
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/0.7.0 #1934 +/- ##
=================================================
+ Coverage 67.71% 67.74% +0.02%
=================================================
Files 299 299
Lines 5290 5301 +11
Branches 968 973 +5
=================================================
+ Hits 3582 3591 +9
- Misses 1708 1710 +2
|
…aram-support-to-transactions-endpoint
sameersubudhi
suggested changes
Nov 22, 2023
services/blockchain-indexer/shared/dataService/business/pendingTransactions.js
Outdated
Show resolved
Hide resolved
sameersubudhi
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes seem to work as expected, except for the issue reported in #1937.
priojeetpriyom
approved these changes
Nov 23, 2023
sameersubudhi
deleted the
1931-add-receivingChainID-request-param-support-to-transactions-endpoint
branch
November 23, 2023 14:46
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #1931
How was it solved?
/transactions
endpoint now returns pending transactions by defaultHow was it tested?
Local