Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix new transactions event payload #1957

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Nov 30, 2023

What was the problem?

This PR resolves #1956

How was it solved?

  • Format transactions before passing event payload to gateway
  • Add configuration for heartbeatAckMaxWaitTime
  • Update docs

How was it tested?

  • Local
  • Integration tests

Add configuration for heartbeatAckMaxWaitTime
Update docs
@nagdahimanshu nagdahimanshu self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1957 (51687f7) into development (62f3626) will decrease coverage by 0.02%.
Report is 4 commits behind head on development.
The diff coverage is 42.85%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1957      +/-   ##
===============================================
- Coverage        67.99%   67.97%   -0.02%     
===============================================
  Files              299      299              
  Lines             5305     5309       +4     
  Branches           977      978       +1     
===============================================
+ Hits              3607     3609       +2     
- Misses            1698     1700       +2     
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <100.00%> (ø)
services/blockchain-indexer/config.js 100.00% <ø> (ø)
...chain-indexer/shared/dataService/business/index.js 100.00% <ø> (ø)
...ces/blockchain-indexer/shared/dataService/index.js 100.00% <ø> (ø)
services/export/config.js 100.00% <ø> (ø)
...ndexer/shared/dataService/business/transactions.js 28.20% <33.33%> (+0.13%) ⬆️

@nagdahimanshu nagdahimanshu force-pushed the 1956-fix-new-transactions-event-payload branch from 526f2a4 to e802147 Compare November 30, 2023 15:57
@nagdahimanshu nagdahimanshu marked this pull request as ready for review November 30, 2023 15:58
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@sameersubudhi sameersubudhi merged commit 6882eaa into development Dec 1, 2023
@sameersubudhi sameersubudhi deleted the 1956-fix-new-transactions-event-payload branch December 1, 2023 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix new transactions event payload
3 participants