Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Empty data in delete transactions event payload #1960

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Dec 1, 2023

What was the problem?

This PR resolves #1958

How was it solved?

  • Add null check before dispatching deleteTransactions signal
  • Fix update.round event payload
  • Update delay to 10s for blocks caching upon error

How was it tested?

Local

@nagdahimanshu nagdahimanshu self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1960 (67759ef) into development (02db4f1) will increase coverage by 0.04%.
Report is 7 commits behind head on development.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1960      +/-   ##
===============================================
+ Coverage        67.99%   68.03%   +0.04%     
===============================================
  Files              299      299              
  Lines             5305     5309       +4     
  Branches           977      978       +1     
===============================================
+ Hits              3607     3612       +5     
+ Misses            1698     1697       -1     
Files Coverage Δ
...ndexer/shared/dataService/business/transactions.js 30.76% <ø> (+2.69%) ⬆️

... and 5 files with indirect coverage changes

@nagdahimanshu nagdahimanshu marked this pull request as ready for review December 1, 2023 13:33
@sameersubudhi sameersubudhi merged commit 3132da6 into development Dec 1, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1958-empty-data-in-delete-transactions-event-payload branch December 1, 2023 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty data in delete transactions event payload
3 participants