Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Top balances endpoint does not consider locked amounts #2019

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #2018

How was it solved?

  • Fixed the indexing logic for total balance to be the sum of available balance and all the locked amounts

How was it tested?

Locally

@sameersubudhi sameersubudhi self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c17581b) 68.33% compared to head (82343ea) 68.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2019   +/-   ##
============================================
  Coverage        68.33%   68.33%           
============================================
  Files              300      300           
  Lines             5429     5429           
  Branches           991      991           
============================================
  Hits              3710     3710           
  Misses            1719     1719           

Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 65e1f43 into development Jan 30, 2024
11 checks passed
@sameersubudhi sameersubudhi deleted the 2018-top-balances-endpoint-does-not-consider-locked-balances branch January 30, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top balances endpoint does not consider locked balances
2 participants