-
Notifications
You must be signed in to change notification settings - Fork 15
Fix transaction history report #2021
Fix transaction history report #2021
Conversation
9936271
to
7802b79
Compare
7802b79
to
da085fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I will go through the transactionExport file again to double check
ddd138d
to
d65822e
Compare
1bc3a76
to
1e9bba2
Compare
1e9bba2
to
cf01cdd
Compare
3cdf63a
to
7bd66a6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #2021 +/- ##
===============================================
- Coverage 68.33% 67.89% -0.44%
===============================================
Files 300 303 +3
Lines 5429 5704 +275
Branches 991 1081 +90
===============================================
+ Hits 3710 3873 +163
- Misses 1719 1831 +112
|
d0c7ea3
to
b81211f
Compare
b81211f
to
5cf84dd
Compare
f720f55
to
c3db14f
Compare
24ca95d
to
cb22381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested scenarios taking regular account, validator account and account with incoming crossChainTransfer and looks good to me. Great job 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What was the problem?
This PR resolves #2020
How was it solved?
How was it tested?