comment: add comments to CompoundTagVariant

LiteLDev · Dec 6, 2023 · ffe216b · ffe216b
1 parent bb22afd
commit ffe216b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/mc/nbt/CompoundTagVariant.h b/src/mc/nbt/CompoundTagVariant.h
@@ -105,7 +105,7 @@ class CompoundTagVariant {
     [[nodiscard]] bool hold() const noexcept {
         return std::holds_alternative<T>(mTagStorage);
     }
-
+    // consistency with json
     [[nodiscard]] bool is_array() const noexcept { return hold<ListTag>(); }
     [[nodiscard]] bool is_binary() const noexcept { return hold<ByteArrayTag>() || hold<IntArrayTag>(); }
     [[nodiscard]] bool is_boolean() const noexcept { return hold<ByteTag>(); }
@@ -114,9 +114,9 @@ class CompoundTagVariant {
     [[nodiscard]] bool is_number_integer() const noexcept {
         return hold<ByteTag>() || hold<ShortTag>() || hold<IntTag>() || hold<Int64Tag>();
     }
-    [[nodiscard]] bool is_number() const noexcept { return is_number_float() || is_number_integer(); }
     [[nodiscard]] bool is_object() const noexcept { return hold<CompoundTag>(); }
     [[nodiscard]] bool is_string() const noexcept { return hold<StringTag>(); }
+    [[nodiscard]] bool is_number() const noexcept { return is_number_float() || is_number_integer(); }
     [[nodiscard]] bool is_primitive() const noexcept { return is_null() || is_string() || is_number() || is_binary(); }
     [[nodiscard]] bool is_structured() const noexcept { return is_array() || is_object(); }
 
@@ -183,7 +183,7 @@ class CompoundTagVariant {
     }
 
     [[nodiscard]] CompoundTagVariant& operator[](std::string const& index) {
-        if (hold<EndTag>()) {
+        if (is_null()) {
             mTagStorage = CompoundTag{};
         }
         if (!hold<CompoundTag>()) {
@@ -213,7 +213,7 @@ class CompoundTagVariant {
     }
 
     void push_back(CompoundTagVariant val) {
-        if (hold<EndTag>()) {
+        if (is_null()) {
             mTagStorage = ListTag{};
         }
         if (!hold<ListTag>()) {