Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 1.0.0-rc.3 #1615

Merged
merged 22 commits into from
Jan 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix version prelease parse
OEOTYAN committed Jan 10, 2025

Verified

This commit was signed with the committer’s verified signature.
derekpierre Derek Pierre
commit 47f478e2e1da997e404097a35243960cb6f83f28
2 changes: 1 addition & 1 deletion src/ll/api/data/Version.h
Original file line number Diff line number Diff line change
@@ -103,7 +103,7 @@ struct PreRelease {
auto tokens = ll::string_utils::splitByPattern(s, ".");
for (auto const& token : tokens) {
std::uint16_t value;
if (detail::from_chars(token.data(), token.data() + token.length(), value); value) {
if (auto result = detail::from_chars(token.data(), token.data() + token.length(), value); result) {
values.emplace_back(value);
} else {
values.emplace_back(std::string{token});